Common Settings Page

[hgluka]

Description

This PR is for the new layout of the Common Settings page, per #3174.
It's still in the early stages. I'm still working on the general structure of the document.

Resolves #3174.

Discussion

As @aartaka mentioned in #3174, we could make the whole thing a form with a "Save" button at the end.

Checklist:

Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.

• Git hygiene:
  • I have pulled from master before submitting this PR
  • There are no merge conflicts.
• I've added the new dependencies as:
  • ASDF dependencies,
  • Git submodules,

    cd /path/to/nyxt/checkout
    git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser

  • and Guix dependencies.
• My code follows the style guidelines for Common Lisp code. See:
  • Norvig & Pitman's Tutorial on Good Lisp Programming Style (PDF)
  • Google Common Lisp Style Guide
• I have performed a self-review of my own code.
• My code has been reviewed by at least one peer. (The peer review to approve a PR counts. The reviewer must download and test the code.)
• Documentation:
  • All my code has docstrings and :documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)
  • I have updated the existing documentation to match my changes.
  • I have commented my code in hard-to-understand areas.
  • I have updated the changelog.lisp with my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).
    • Changelog update should be a separate commit.
  • I have added a migration.lisp entry for all compatibility-breaking changes.
  • (If this changes something about the features showcased on Nyxt website) I have these changes described in the new/existing article at Nyxt website or will notify one of maintainters to do so.
• Compilation and tests:
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works. (If possible.)
  • I ran the tests locally ((asdf:test-system :nyxt) and (asdf:test-system :nyxt/gi-gtk)) and they pass.

[aadcg]

As @aartaka mentioned in #3174, we could make the whole thing a form with a "Save" button at the end.

Was it agreed upon though? I don't think that qualifies as user-friendly by any means. As of today, a change in a parameter is registered immediately. Such a change would be a regression in my opinion. CC @jmercouris.

[lansingthomas]

Additional spec for the New Buffer Settings section:

Colors for the display area:

background:
(background-) #ECECEC in light theme, and #333333 in dark theme

Border and text:

• corner rounding on the whole object (~3px)
• the border and text are the same color in both light and dark theme.
  • light #909090
  • dark #A55D2F

[jmercouris]

I agree, it would probably be a regression, however I leave the last word to Thomas.

Edit: The oracle has spoken, the save button shall be avoided.

[hgluka]

I got configure-slot to cooperate! Now we can give it multiple sources, with or without marks, "postprocess" the result if necessary, etc.
I think that's finally all the different ways of interacting with settings done. Now I just need to add the second column with the documentation and make the whole page use the side-tab layout that @lansingthomas proposed. Should be done soon!

[lansingthomas]

Now I just need to add the second column with the documentation and make the whole page use the side-tab layout

Yes! I am looking forward to seeing it.

[hgluka]

Side tab layout is done!
Here it is:

[lansingthomas]

Niiiice

[hgluka]

I think this is ready for review. There might be a bit more cleaning up to do, but everything works and it looks (close to) how @lansingthomas imagined it, I hope! Let me know if I missed anything.

CC @jmercouris

[jmercouris]

Will review, thank you!

[lansingthomas]

The headings should be title case.
Same with line 127 -- the "Buffer Settings" side panel text

[jmercouris]

Looks very close to me Luka. I may tweak some CSS and merge it, pending your permission, and a final review with Thomas on Tuesday, does that sound OK?

[hgluka]

@jmercouris Sure, go ahead! I didn't really think through the CSS, I just cobbled it together so that everything looks okay.

[jmercouris]

Don't tell me that I did this merge wrong @aadcg I swear I did everything correct! :-O

[jmercouris]

Thanks Luka :-)

[aartaka]

We like to use `%something%` in the Nyxt codebase even though `%something` is standard in Common Lisp. Just for next time :-)

No wait, %SOMETHING% is for variables, while functions only have a leading percent sign.

[jmercouris]

i see, thanks for the clarification

[aadcg]

@jmercouris it was merged properly. Thanks.

[aadcg]

What failed was the changelog entry. CC @hgluka @jmercouris.

[hgluka]

@aadcg Should I add it as a commit directly to master?

[aadcg]

A serious review wasn't carried out in this PR (see #3209). This is not acceptable. Features can't be broken from the start.

[aadcg]

@hgluka No. I'll do it in the release process. Thanks.