Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review flatpak manifest #3146

Closed
wants to merge 0 commits into from
Closed

Review flatpak manifest #3146

wants to merge 0 commits into from

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Aug 31, 2023

Description

This PR depends on #3145 and can only be merged after it. I'll rebase it once it has been merged. Reviewers, only the latest 2 commits are exclusive to this PR.

Nyxt has been added to Flathub so why do we still need to build it from a git checkout? Because we should be able to run Nyxt as a Flatpak from arbritary commits. The Flathub Nyxt repository serves for the purpose of distributing tagged releases only.

Since the Flatpak manifest is a build recipe, I considered a good idea to move it to build-scripts. No need to "pollute" our root directory.

Checklist:

Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.

  • Git hygiene:
    • I have pulled from master before submitting this PR
    • There are no merge conflicts.
  • I've added the new dependencies as:
    • ASDF dependencies,
    • Git submodules,
      cd /path/to/nyxt/checkout
      git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser
    • and Guix dependencies.
  • My code follows the style guidelines for Common Lisp code. See:
  • I have performed a self-review of my own code.
  • My code has been reviewed by at least one peer. (The peer review to approve a PR counts. The reviewer must download and test the code.)
  • Documentation:
    • All my code has docstrings and :documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)
    • I have updated the existing documentation to match my changes.
    • I have commented my code in hard-to-understand areas.
    • I have updated the changelog.lisp with my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).
      • Changelog update should be a separate commit.
    • I have added a migration.lisp entry for all compatibility-breaking changes.
    • (If this changes something about the features showcased on Nyxt website) I have these changes described in the new/existing article at Nyxt website or will notify one of maintainters to do so.
  • Compilation and tests:
    • My changes generate no new warnings.
    • I have added tests that prove my fix is effective or that my feature works. (If possible.)
    • I ran the tests locally ((asdf:test-system :nyxt) and (asdf:test-system :nyxt/gi-gtk)) and they pass.

@aadcg aadcg requested a review from jmercouris August 31, 2023 09:54
@aadcg aadcg closed this Sep 10, 2023
@aadcg aadcg deleted the review-flatpak branch September 10, 2023 21:33
@aadcg
Copy link
Member Author

aadcg commented Sep 10, 2023

Merged via 48547f9 and 644613c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant