Add render-menu function. #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It not *only* lists commands of the pcakge, it ALSO lists commands within the Nyxt package. Probably because this function is primarily in service of the prompt-buffer execute-command function.
jmercouris
commented
Dec 21, 2023
| @@ -441,8 +441,7 @@ The `input' should be a valid Lisp code `read'-able in the `eval-package'. | |||
| `(.input-area | |||
| :background-color ,theme:secondary | |||
| :width "99%" | |||
| :padding "0.5rem" | |||
| :margin "1rem") | |||
| :padding "0.5rem") | |||
There was a problem hiding this comment.
I don't believe this change merits a mention in the changelog.
Closed
|
Obligatory screenshot:
|
message.lisp: Convert to using new top-menu. buffer-listing.lisp: adapt to use the new menu. history.lisp: use menu bar. download.lisp: Add menu to download page. bookmark.lisp: add menu to bookmark menu. macro-edit.lisp: Add render menu to edit macro. plaintext-editor.lisp: Add a menu for the editor.
This prevents scrolling in the X direction.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It also a fixes an issue where editor buffers could not have execute Lisp URLs. It fixes this by classing urls starting with
editoras internal URLs.Fixes #3162
Checklist:
(asdf:test-system :nyxt/gi-gtk))