Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fullscreen and maximized logic #3441

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Fix fullscreen and maximized logic #3441

merged 2 commits into from
Jul 27, 2024

Commits on Jul 27, 2024

  1. Refactor fullscreen and maximized window logic. 

    The new foreign interface architecture handles the state of the relevant window
slots (fullscreen-p, maximized-p) instead of setf-ing them on the renderer
packages.  This replaces the need for the :skip-renderer-resize keyword.

Fixed bug in toggle-message-buffer, where the height of the buffer was being
probed incorrectly.

Refactor the handling of the window-state-event in GTK.  It didn't account for
events where the window is no longer fullscreen or maximized.

Simplify implementation of toggle-fullscreen, toggle-maximize,
toggle-status-buffer and toggle-message-buffer.

As for the fullscreen rationale regarding the UI: when a fullscreen event is
emitted by JS's Fullscreen API, the status and message buffers are hidden.  For
all other fullscreen events, the status and message buffers are kept.  Note that
we can't hide the message buffer on fullscreen since then there would be no way
to get that important piece of information.  On typical browsers, the equivalent
of the message buffer is a dynamically visible toolbar at the bottom left (and
it is still displayed on fullscreen).
    @aadcg
    aadcg committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    341c2bc View commit details
    Browse the repository at this point in the history

  2. changelog: Mention fullscreen logic fix.

    @aadcg
    aadcg committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    ed26e87 View commit details
    Browse the repository at this point in the history