Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trainee attendance feature FN #348

Merged
merged 1 commit into from
Nov 29, 2023
Merged

trainee attendance feature FN #348

merged 1 commit into from
Nov 29, 2023

Conversation

bryan936M
Copy link
Contributor

@bryan936M bryan936M commented Nov 15, 2023

PR Description

Please include a brief description of the pull request you want to raise.

  • This PR is for merging this new attendance feature to the main branch.

Description of tasks that were expected to be completed

List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check evey completed task.

  • Integration with backend API
  • Re-design frontend UI

How has this been tested?

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Number of Commits

1
The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Screenshots (If appropriate)

Screenshot 2023-11-17 110804

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 5:29pm

@bryan936M bryan936M changed the title Intergrating with the API trainee attendance feature FN Nov 17, 2023
@bryan936M bryan936M force-pushed the ft-trainee-attendance-UI branch from 69ac459 to d730ae6 Compare November 22, 2023 10:04
@bryan936M bryan936M force-pushed the ft-trainee-attendance-UI branch from d730ae6 to 3a2ab4a Compare November 23, 2023 13:10
Copy link
Contributor

@Gabriel-mdv Gabriel-mdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no attendance table.
image

@ceelogre ceelogre merged commit 4e5fc78 into develop Nov 29, 2023
4 checks passed
@ceelogre ceelogre deleted the ft-trainee-attendance-UI branch November 29, 2023 22:40
bryan936M added a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants