Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing update feedback #361

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fixing update feedback #361

merged 1 commit into from
Dec 21, 2023

Conversation

Dyves1
Copy link
Contributor

@Dyves1 Dyves1 commented Dec 2, 2023

PR Description

Admin to see the updated feedback before approve

Description of tasks that were expected to be completed

  • Coordinator should also update the feedback
  • Admin be able to get the feedback updated

How has this been tested?

  • Visit the deployed version link
  • Login with the coordinator credentials try to update the trainee ratings
  • Logout the coordinator credentials
  • Login with also admin credentials and go to updated ratings
  • View the feedback by clicking on View icon

Number of Commits

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Screenshots (If appropriate)

Screenshot 2023-12-20 123010 Screenshot 2023-12-20 123024 Screenshot 2023-12-20 123042

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 9:15am

Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you only update Feedback, the toast says that there are no changes made. Also, the change doesn't appear in the admin panel.
image

@ceelogre ceelogre merged commit 72cdf55 into develop Dec 21, 2023
4 checks passed
@ceelogre ceelogre deleted the fix-update-feedback branch June 27, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants