Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187570716 - chore :setup unit teting with jest #2

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

jamesndekezi
Copy link
Collaborator

@jamesndekezi jamesndekezi commented May 12, 2024

What does this PR does?

this PR setup initila unit testing for our backend api

How can this be tested?

1.Clone repo
2. checkout to ft-setup-testing
3. install dependencies
4. run test by npm run test

Pivot tracker id -> #187570716

##screenshots
mnbcxx

Copy link
Collaborator

@mugishaj092 mugishaj092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi James, thanks for the pull request. Just a quick note, the task description specified using Mocha Chai for testing, but I noticed Jest was used instead. Let's ensure consistency with the task requirements. Could you please revise the tests to use Mocha Chai as described? Appreciate your attention to this detail!

@jamesndekezi jamesndekezi requested a review from mugishaj092 May 15, 2024 11:05
@vegetason vegetason requested review from vegetason and removed request for vegetason May 15, 2024 11:29
Copy link
Collaborator

@mugishaj092 mugishaj092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@jamesndekezi jamesndekezi changed the title #187570716 - chore :setup unit teting with jest #187570716 - chore :setup unit teting with Mocha and Chai May 15, 2024
Copy link

gitguardian bot commented May 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

clearMocks: true,
resetMocks: true,
restoreMocks: true,
clearMocks: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate key 'clearMocks'.

@jamesndekezi jamesndekezi changed the title #187570716 - chore :setup unit teting with Mocha and Chai #187570716 - chore :setup unit teting with jest May 20, 2024
@jamesndekezi jamesndekezi requested a review from SHYAKA-Aime May 20, 2024 07:17
@furebo furebo merged commit a85a8f9 into main May 20, 2024
3 of 4 checks passed
kennyg37 pushed a commit that referenced this pull request May 31, 2024
#187570716 - chore :setup unit teting with jest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants