#187419123-Feature Users should be able to Update their Password #12

Jovz19200 · 2024-06-21T13:45:08Z

what Does this PR do?

Logged user are able to update their password

How to test the functionality ?

Checkout to the preview deployment of this PR
checkout to the || URL/login (login is prerequisite to be able to update the PW)
checkout to the || URL/update-password
follow the procedure and update the password
verify if the password has been updated by perhaps trying to log in again

vercel · 2024-06-21T13:45:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eagles-ec-fe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2024 2:00pm

codeclimate · 2024-06-21T13:45:29Z

src/redux/api/updatePasswordApiSlice.ts

+UpdatePasswordPayload,
+{ rejectValue: UpdatePasswordError }
+>("updatePassword", async (payload, { rejectWithValue }) => {
+  try {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-06-21T13:45:29Z

src/redux/api/updatePasswordApiSlice.ts

+  initialState,
+  reducers: {},
+  extraReducers: (builder) => {
+    builder


Similar blocks of code found in 2 locations. Consider refactoring.

codecov-commenter · 2024-06-21T13:47:21Z

Codecov Report

Attention: Patch coverage is 72.37569% with 50 lines in your changes missing coverage. Please review.

Project coverage is 69.57%. Comparing base (88b567f) to head (bd66387).
Report is 2 commits behind head on dev.

Files	Patch %	Lines
src/redux/api/updatePasswordApiSlice.ts	37.50%	15 Missing ⚠️
src/components/password/UpdateModal.tsx	58.62%	12 Missing ⚠️
src/pages/otpVerfication.tsx	86.07%	11 Missing ⚠️
src/pages/Login.tsx	0.00%	6 Missing ⚠️
src/redux/api/otpApiSclice.ts	78.26%	5 Missing ⚠️
src/components/common/auth/Password.tsx	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev      #12      +/-   ##
==========================================
+ Coverage   64.88%   69.57%   +4.69%     
==========================================
  Files          13       20       +7     
  Lines         131      309     +178     
  Branches        5       25      +20     
==========================================
+ Hits           85      215     +130     
- Misses         46       94      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gitguardian · 2024-06-24T17:59:42Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
12081800	Triggered	Generic Password	`725aa7a`	src/test/updatePasswordApiSlice.test.tsx	View secret
12081800	Triggered	Generic Password	`725aa7a`	src/test/updatePasswordApiSlice.test.tsx	View secret
12081800	Triggered	Generic Password	`725aa7a`	src/test/updatePasswordApiSlice.test.tsx	View secret
12081800	Triggered	Generic Password	`725aa7a`	src/test/updatePasswordApiSlice.test.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

codeclimate · 2024-06-24T18:00:07Z

src/__test__/updatePassword.test.tsx

+import UpdatePasswordmod from "../components/password/UpdateModal";
+import store from "../redux/store";
+
+test("test update password", () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-06-24T18:00:07Z

src/__test__/updatePassword.test.tsx

+  userEvent.click(updateButton);
+});
+
+test("test update password with mismatching new password and confirm password", () => {


Similar blocks of code found in 2 locations. Consider refactoring.

#187419122 Seller Authentication and Two factor authentication for seller

codeclimate · 2024-06-25T14:00:25Z

Code Climate has analyzed commit 725aa7a and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	4

View more on Code Climate.

codeclimate bot reviewed Jun 21, 2024

View reviewed changes

Jovz19200 force-pushed the ft-update-password-#187419123 branch from e62e69d to 864885d Compare June 21, 2024 15:03

vercel bot deployed to Preview June 21, 2024 15:04 View deployment

Jovz19200 force-pushed the ft-update-password-#187419123 branch from 864885d to bb05637 Compare June 23, 2024 10:26

vercel bot deployed to Preview June 23, 2024 10:26 View deployment

Jovz19200 force-pushed the ft-update-password-#187419123 branch from bb05637 to f3069fe Compare June 24, 2024 17:59

vercel bot deployed to Preview June 24, 2024 18:00 View deployment

codeclimate bot reviewed Jun 24, 2024

View reviewed changes

Jovz19200 force-pushed the ft-update-password-#187419123 branch from f3069fe to a1de45f Compare June 24, 2024 18:04

vercel bot deployed to Preview June 24, 2024 18:05 View deployment

Jovz19200 added the In progress a work in progress label Jun 24, 2024

Jovz19200 force-pushed the ft-update-password-#187419123 branch from a1de45f to 83992b0 Compare June 24, 2024 18:28

vercel bot had a problem deploying to Preview June 24, 2024 18:29 Failure

Jovz19200 force-pushed the ft-update-password-#187419123 branch from 83992b0 to ff03571 Compare June 24, 2024 18:30

vercel bot had a problem deploying to Preview June 24, 2024 18:30 Failure

Jovz19200 force-pushed the ft-update-password-#187419123 branch from ff03571 to fa917cc Compare June 24, 2024 18:40

vercel bot had a problem deploying to Preview June 24, 2024 18:40 Failure

Jovz19200 force-pushed the ft-update-password-#187419123 branch from fa917cc to aa84faf Compare June 24, 2024 19:46

vercel bot had a problem deploying to Preview June 24, 2024 19:46 Failure

Jovz19200 force-pushed the ft-update-password-#187419123 branch from aa84faf to 6422830 Compare June 24, 2024 21:46

vercel bot deployed to Preview June 24, 2024 21:46 View deployment

Jovz19200 force-pushed the ft-update-password-#187419123 branch from 6422830 to bd66387 Compare June 24, 2024 21:59

vercel bot deployed to Preview June 24, 2024 22:00 View deployment

Merge pull request #6 from atlp-rwanda/ft-seller-auth-2f-#187419122

725aa7a

#187419122 Seller Authentication and Two factor authentication for seller

Jovz19200 force-pushed the ft-update-password-#187419123 branch from bd66387 to 725aa7a Compare June 25, 2024 13:59

vercel bot deployed to Preview June 25, 2024 14:00 View deployment

Jovz19200 closed this Jun 25, 2024

Jovz19200 added bug Something isn't working and removed In progress a work in progress labels Jun 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#187419123-Feature Users should be able to Update their Password #12

#187419123-Feature Users should be able to Update their Password #12

Jovz19200 commented Jun 21, 2024

vercel bot commented Jun 21, 2024 •

edited

Loading

codeclimate bot Jun 21, 2024

codeclimate bot Jun 21, 2024

codecov-commenter commented Jun 21, 2024 •

edited

Loading

gitguardian bot commented Jun 24, 2024 •

edited

Loading

codeclimate bot Jun 24, 2024

codeclimate bot Jun 24, 2024

codeclimate bot commented Jun 25, 2024

#187419123-Feature Users should be able to Update their Password #12

#187419123-Feature Users should be able to Update their Password #12

Conversation

Jovz19200 commented Jun 21, 2024

what Does this PR do?

How to test the functionality ?

vercel bot commented Jun 21, 2024 • edited Loading

codeclimate bot Jun 21, 2024

Choose a reason for hiding this comment

codeclimate bot Jun 21, 2024

Choose a reason for hiding this comment

codecov-commenter commented Jun 21, 2024 • edited Loading

Codecov Report

gitguardian bot commented Jun 24, 2024 • edited Loading

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

codeclimate bot Jun 24, 2024

Choose a reason for hiding this comment

codeclimate bot Jun 24, 2024

Choose a reason for hiding this comment

codeclimate bot commented Jun 25, 2024

vercel bot commented Jun 21, 2024 •

edited

Loading

codecov-commenter commented Jun 21, 2024 •

edited

Loading

gitguardian bot commented Jun 24, 2024 •

edited

Loading