Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187419133 Users should be able to chat #19

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

Heisjabo
Copy link
Collaborator

@Heisjabo Heisjabo commented Jul 7, 2024

What does this PR do?

This PR Adds private and public chat functionality

Description of Task to be completed?

  • a user should be able to read previous chats
  • a user should be able to post a public chat
  • users should be able to chat privately
  • users should be able to receive messages in real time

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ft-chat-#187419133.
  3. Run npm install to install dependencies.
  4. Run npm run dev to start the development server and login
  5. navigate to /chat
  6. Test if everything is working as expected by sending and receiving messages

What are the relevant pivotal tracker stories?

Delivers #187419133

screenshots

Design

MacBook Pro 14_ - 1

Implementation

Screenshot 2024-07-22 at 4 27 03 PM Screenshot 2024-07-22 at 4 27 20 PM Screenshot 2024-07-22 at 4 27 49 PM

Copy link

vercel bot commented Jul 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:34pm

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 71.98068% with 58 lines in your changes missing coverage. Please review.

Project coverage is 72.81%. Comparing base (837a593) to head (92cab61).

Files Patch % Lines
src/page-sections/chat/UserList.tsx 51.64% 44 Missing ⚠️
src/redux/api/loginApiSlice.ts 14.28% 6 Missing ⚠️
src/page-sections/chat/ChatWindow.tsx 85.71% 3 Missing and 2 partials ⚠️
src/pages/Login.tsx 50.00% 2 Missing ⚠️
src/redux/api/api.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #19      +/-   ##
==========================================
+ Coverage   72.32%   72.81%   +0.48%     
==========================================
  Files          70       75       +5     
  Lines        1485     1703     +218     
  Branches      196      246      +50     
==========================================
+ Hits         1074     1240     +166     
- Misses        395      453      +58     
+ Partials       16       10       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@soleil00 soleil00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- a user should be able to read previous chats
- a user should be able to post a public chat
- users should be able to chat privately

Delivers #187419133
@Heisjabo Heisjabo force-pushed the ft-chat-#187419133 branch from a9267cc to 92cab61 Compare July 22, 2024 18:34
Copy link

codeclimate bot commented Jul 22, 2024

Code Climate has analyzed commit 92cab61 and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit f306d90 into dev Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants