Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187419115 Configure ESLint and Git Pre commit hook to run tests and ESlint format #2

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Heisjabo
Copy link
Collaborator

@Heisjabo Heisjabo commented Jun 8, 2024

What does this PR do?

This Configures Eslint and git precommit hook to run tests and lint before commits and adds Hound CI

Description of Task to be completed?

  • configure eslint
  • configure prettier for code formatting
  • Configure Hound CI and add a badge in Readme

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ch-eslint-precommit-#187419115.
  3. Run npm install to install dependencies.
  4. Add any changes and try committing to check for precommit hook
  5. Run npm run lint to check lint errors and npm run lint:fix to fix lint errors
  6. Run npm run prettier to format codes with prettier ( you don't need to have prettier installed )

What are the relevant pivotal tracker stories?

Delivers #187419115

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 0:23am

Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@niyobertin niyobertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Jovz19200 Jovz19200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

- configure eslint and prettier format

Delivers #187419115
@teerenzo teerenzo merged commit e292e86 into dev Jun 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants