feat(admin):admin can view statistics #80
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
src/controllers/adminStatistics.ts
Outdated
| @@ -0,0 +1,64 @@ | |||
| import { Request, Response } from "express"; | |||
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
src/routes/adminStatsRoute.ts
Outdated
| @@ -0,0 +1,13 @@ | |||
| import express from "express"; | |||
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Tuyisenge2
requested review from
leandreAlly,
JacquelineTuyisenge and
cyusasnave
src/controllers/adminStatistics.ts
Outdated
| export const adminStatistics = async (req: Request, res: Response) => { | ||
| try { | ||
| const admin_token = req.headers.authorization?.split(" ")[1]; | ||
| if (admin_token) { |
There was a problem hiding this comment.
As long as we have middleware for checking if user is admin, we don't need to use these checking in controller.
just remove it and middleware will do the job.
Tuyisenge2
force-pushed
the
feat-admin-stat
branch
from
fc9b027 to
0b3a169
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| const activeBuyers = allBuyers.rows.filter((item) => item.isActive); | ||
| const activeSellers = allSellers.rows.filter((item) => item.isActive); | ||
| const allOrders = await Order.findAndCountAll({ | ||
| include: { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
Tuyisenge2
force-pushed
the
feat-admin-stat
branch
from
0b3a169 to
c3c8926
Compare
|
Code Climate has analyzed commit c3c8926 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 50.0% (60% is the threshold). This pull request will bring the total coverage in the repository to 96.4% (-0.8% change). View more on Code Climate. |
What does this PR do?
A admin can have some statistics of all app.
How should this be manually tested?
Clone the repo and cd into it
Checkout to feat-admin-stat and run npm install
Run npm run dev to start the application locally
login as admin and navigate to /admin/stat