Merge pull request DSpace#9076 from amgciadev/fix-9070-b

Fix to prevent workflow tasks configured to be queued from running automatically
atmire · Nov 8, 2023 · a08145e · a08145e
2 parents 60d4bca + 257d22f
commit a08145e
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 44 deletions.
diff --git a/dspace-api/src/main/java/org/dspace/curate/Curation.java b/dspace-api/src/main/java/org/dspace/curate/Curation.java
@@ -152,17 +152,10 @@ private long runQueue(TaskQueue queue, Curator curator) throws SQLException, Aut
                 super.handler.logInfo("Curating id: " + entry.getObjectId());
             }
             curator.clear();
-            // does entry relate to a DSO or workflow object?
-            if (entry.getObjectId().indexOf('/') > 0) {
-                for (String taskName : entry.getTaskNames()) {
-                    curator.addTask(taskName);
-                }
-                curator.curate(context, entry.getObjectId());
-            } else {
-                // TODO: Remove this exception once curation tasks are supported by configurable workflow
-                // e.g. see https://github.com/DSpace/DSpace/pull/3157
-                throw new IllegalArgumentException("curation for workflow items is no longer supported");
+            for (String taskName : entry.getTaskNames()) {
+                curator.addTask(taskName);
             }
+            curator.curate(context, entry.getObjectId());
         }
         queue.release(this.queue, ticket, true);
         return ticket;

diff --git a/dspace-api/src/main/java/org/dspace/curate/XmlWorkflowCuratorServiceImpl.java b/dspace-api/src/main/java/org/dspace/curate/XmlWorkflowCuratorServiceImpl.java
@@ -13,6 +13,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.lang3.StringUtils;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.dspace.authorize.AuthorizeException;
@@ -139,40 +140,47 @@ public boolean curate(Curator curator, Context c, XmlWorkflowItem wfi)
             item.setOwningCollection(wfi.getCollection());
             for (Task task : step.tasks) {
                 curator.addTask(task.name);
-                curator.curate(c, item);
-                int status = curator.getStatus(task.name);
-                String result = curator.getResult(task.name);
-                String action = "none";
-                switch (status) {
-                    case Curator.CURATE_FAIL:
-                        // task failed - notify any contacts the task has assigned
-                        if (task.powers.contains("reject")) {
-                            action = "reject";
-                        }
-                        notifyContacts(c, wfi, task, "fail", action, result);
-                        // if task so empowered, reject submission and terminate
-                        if ("reject".equals(action)) {
-                            workflowService.sendWorkflowItemBackSubmission(c, wfi,
-                                    c.getCurrentUser(), null,
-                                    task.name + ": " + result);
-                            return false;
-                        }
-                        break;
-                    case Curator.CURATE_SUCCESS:
-                        if (task.powers.contains("approve")) {
-                            action = "approve";
-                        }
-                        notifyContacts(c, wfi, task, "success", action, result);
-                        if ("approve".equals(action)) {
-                            // cease further task processing and advance submission
-                            return true;
-                        }
-                        break;
-                    case Curator.CURATE_ERROR:
-                        notifyContacts(c, wfi, task, "error", action, result);
-                        break;
-                    default:
-                        break;
+                // Check whether the task is configured to be queued rather than automatically run
+                if (StringUtils.isNotEmpty(step.queue)) {
+                    // queue attribute has been set in the FlowStep configuration: add task to configured queue
+                    curator.queue(c, item.getID().toString(), step.queue);
+                } else {
+                    // Task is configured to be run automatically
+                    curator.curate(c, item);
+                    int status = curator.getStatus(task.name);
+                    String result = curator.getResult(task.name);
+                    String action = "none";
+                    switch (status) {
+                        case Curator.CURATE_FAIL:
+                            // task failed - notify any contacts the task has assigned
+                            if (task.powers.contains("reject")) {
+                                action = "reject";
+                            }
+                            notifyContacts(c, wfi, task, "fail", action, result);
+                            // if task so empowered, reject submission and terminate
+                            if ("reject".equals(action)) {
+                                workflowService.sendWorkflowItemBackSubmission(c, wfi,
+                                        c.getCurrentUser(), null,
+                                        task.name + ": " + result);
+                                return false;
+                            }
+                            break;
+                        case Curator.CURATE_SUCCESS:
+                            if (task.powers.contains("approve")) {
+                                action = "approve";
+                            }
+                            notifyContacts(c, wfi, task, "success", action, result);
+                            if ("approve".equals(action)) {
+                                // cease further task processing and advance submission
+                                return true;
+                            }
+                            break;
+                        case Curator.CURATE_ERROR:
+                            notifyContacts(c, wfi, task, "error", action, result);
+                            break;
+                        default:
+                            break;
+                    }
                 }
                 curator.clear();
             }