This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
fix: Handle -> Local for node 12 compat #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maintainers, can you please merge this PR and share a new build? |
|
I tested this change with Electron 5.0.0-beta.8 (by pointing my |
ghost
mentioned this pull request
|
Thanks for the contribution! ❤️ Apologies for the delay reviewing it, I'm going to merge it and publish a new version of |
Merged
|
A new version has just been published, but after merging this PR builds on CI on Node v12 started failing (example), so I've disabled Node v12 from being tested on CI. If anybody wants to fix Node v12 builds I'll be happy to review the PR |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming Node12 (and Electron 5) will ship with a V8 that finally removes
Handle(which was deprecated some years ago.)Ref: https://electronjs.org/blog/nodejs-native-addons-and-electron-5