Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Reword issue-opening part of the error tooltip #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

winstliu
Copy link
Contributor

@winstliu winstliu commented Feb 9, 2018

Please be sure to read the contributor's guide before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Modify the part of the error tooltip that suggests opening an issue.
Before: If the problem persists, visit [atom/teletype] and open an issue.
After: If the problem persists, please [open an issue].

Alternate Designs

Alternate wording. I am open to suggestions.

Benefits

I think this makes it clearer that the issue will be prefilled rather than asking you to fill out the information yourself.

Possible Drawbacks

Loss of atom/teletype in the issue message.

Verification Process

Turn off internet and look at the error component. Click on the "open an issue" part to make sure it leads to a prefilled issue template.

Applicable Issues

#317 (comment)

Copy link
Contributor

@jasonrudolph jasonrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @50Wliu.

I explored a few other potential phrasings, but I haven't identified anything that seems like a real winner. I'm happy to merge this pull request as is, but I'll offer one alternative to see what you think:

If the problem persists, please open an issue to share these diagnostics.

If you like that better, feel free to make that update and merge this pull request.

If you like it better as is, feel free to merge the pull request as is.

Thanks for taking the time to make this improvement. 🙇

Copy link

@fridayygn fridayygn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [ ]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants