Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fix compile script on Windows #280

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

Arcanemagus
Copy link
Contributor

@Arcanemagus Arcanemagus commented Dec 11, 2017

npm uses a CMD based environment for running scripts on Windows, which has no emulation of the cp command. Bring in a development dependency on cpy-cli and use that in the compile script to allow errorless installation on Windows.

Alternative options:

  • Some Grunt script since it is already a dependency?
  • copyfiles is more downloaded, but cpy-cli seems to actually duplicate the behavior of cp

Fixes #219.

@Arcanemagus
Copy link
Contributor Author

WARNING: That looks like an excessive amount of deletions in the package-lock.json to me...

@winstliu
Copy link
Contributor

WARNING: That looks like an excessive amount of deletions in the package-lock.json to me...

Ha, sounds like the same thing as what happened to me in #276. Are you using npm 5.6.0? I think that might fix it.

Also, fixes #219. This will make my life much easier whenever I have to work on text-buffer 😍.

@Arcanemagus
Copy link
Contributor Author

Are you using npm 5.6.0? I think that might fix it.

I am, so it must not fix it... if it's actually a problem?

PS C:\foo\text-buffer> npm --version
5.6.0
PS C:\foo\text-buffer> node --version
v9.2.1

npm uses a `CMD` based environment for running scripts on Windows, which
has no emulation of the `cp` command. Bring in a development dependency
on `cpy-cli` and use that in the `compile` script to allow errorless
installation on Windows.
@Arcanemagus
Copy link
Contributor Author

Rebased on master, the package-lock.json diff is a lot saner this time around. The majority of the changes to this file are just removing "dev": true from a bunch of packages, the additions for cpy-cli, and updating of superstring to 2.2.17.

@smashwilson smashwilson merged commit 38e3a32 into atom:master Mar 29, 2018
@smashwilson
Copy link
Contributor

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants