build: allow for linux/amd64 profiles on docker builds
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 66.63% 68.34% +1.71%
==========================================
Files 43 46 +3
Lines 7646 8931 +1285
==========================================
+ Hits 5095 6104 +1009
- Misses 2551 2827 +276 |
jorgeantonio21
approved these changes
Feb 15, 2025
| context: https://github.com/EricLBuehler/mistral.rs.git | ||
| dockerfile: Dockerfile | ||
| image: ghcr.io/ericlbuehler/mistral.rs:cpu-0.4 | ||
| platform: linux/amd64 |
There was a problem hiding this comment.
I believe we want to have support for arm64 in here as well (at least, building from source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can now run
export PLATFORM=linux/amd64Then
COMPOSE_PROFILES=mistralrs-cpu,non-confidential docker compose up -dThis builds off the fixes in #409