Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github CI linter #556

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix github CI linter #556

wants to merge 2 commits into from

Conversation

mpetrowi
Copy link
Contributor

@mpetrowi mpetrowi commented Feb 28, 2023

Enable linter and update GEMS.
Note that the ims-lti GEM has been updated, which was needed to update octokit and faraday.

https://www.pivotaltracker.com/story/show/184583946

@@ -31,7 +31,7 @@ gem "devise_invitable"
gem "devise-two-factor" # TOTP for devise
gem "rqrcode", "~> 2.1" # Generate QR codes for TOTP
gem "strong_password"
gem "ims-lti", "~> 2.1.5" # IMS LTI tool consumers and providers
gem "ims-lti", "~> 2.3.3" # IMS LTI tool consumers and providers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem ims-lti should appear before strong_password.

@mpetrowi mpetrowi requested a review from dspencer001 February 28, 2023 15:32
@mpetrowi mpetrowi changed the title Fix gitlab CI linter Fix github CI linter Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants