feat(x/gov): burn deposit if no votes > BurnDepositNoThreshold
#90
Conversation
wwith 0.7 as default value
update default value to 0.8
|
actually, looking at this again I think we made the same mistake in |
Good catch, I converted all to |
| @@ -419,5 +423,16 @@ func (p Params) ValidateBasic() error { | |||
| return fmt.Errorf("minimum initial deposit decrease ratio too large: %s", minInitialDepositDecreaseRatio) | |||
| } | |||
|
|
|||
| burnDepositNoThreshold, err := sdk.NewDecFromStr(p.BurnDepositNoThreshold) | |||
There was a problem hiding this comment.
We need to add a check for threshold, law and amendment threshold
so that the burnDepositNoThreshold > 1 - threshold (or the burn would happen with less than no votes to make a proposal fail, which makes no sense since the proposal would mean is passing)
the same check goes for law and amendment thresholds
There was a problem hiding this comment.
If the proposal is passing, the burnDepositNoThreshold is not checked, so the burn would not happen anyway. But I will still do this burnDepositNoThreshold > 1 - threshold check so the condition is not tied to the order of code execution.
There was a problem hiding this comment.
done here 3788dbb
x/gov/types/v1/params.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("invalid burnDepositNoThreshold string: %w", err) | ||
| } | ||
| if !burnDepositNoThreshold.IsPositive() { |
There was a problem hiding this comment.
I would replace this check with the burnDepositNoThreshold > 1 - threshold && burnDepositNoThreshold > 1 - lawThreshold && && burnDepositNoThreshold > 1 - amendmentThreshold
Co-authored-by: Giuseppe Natale <[email protected]>
BurnDepositNoThresholdhas a default value of0.8.