Fix: add missing is_number check to fconv opcode #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the Erlang code that can trigger a crash (or a badarith with this PR ?) |
bettio
force-pushed
the
check-fconv-arg
branch
from
7755324
to
fe559d5
Compare
I was able to make a test case, I confirm that badarith is the right error. I added the test case as part of our test suite. |
term_conv_to_float expects a valid number term. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
check-fconv-arg
branch
from
fe559d5
to
1fc7ffd
Compare
pguyot
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fconvtakes also registers as argument, hence they might contain a value that is not a valid number term.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later