Fix issues in http_server #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w47/http-server-fixes
branch
from
f35074b to
6383166
Compare
|
confirmed working on esp32, using system_info_server.erl (which crashes /system/info on 0.6.5 release). Would like to see this in 0.6 branch, but either way🎉 |
petermm
approved these changes
Nov 20, 2024
bettio
requested changes
Nov 21, 2024
pguyot
force-pushed
the
w47/http-server-fixes
branch
2 times, most recently
from
0af4948 to
a6161b4
Compare
Fix a bug where http_server would fail to send a reply with integers.
Fix another bug where http_server crashed with badmatch if connection was
closed, including because of previous bug.
Also fix socket_driver to return `{gen_tcp, closed}` when socket is closed on
Linux instead of `{gen_tcp, {recv, 104}}`
Fixes atomvm#1366
Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w47/http-server-fixes
branch
from
a6161b4 to
652c074
Compare
bettio
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{gen_tcp, closed}when socket is closed on Linux instead of{gen_tcp, {recv, 104}}Fixes #1366
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later