Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a future warning and error appearing on get_quote_table and get_live_price #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

azwanzuharimi
Copy link

@azwanzuharimi azwanzuharimi commented Oct 10, 2023

Fixed a future warning of the following functions:

  1. get_live_price
  • FutureWarning: Series.getitem treating keys as positions is deprecated. In a future version, integer keys will always be treated as labels (consistent with DataFrame behavior). To access a value by position, use ser.iloc[pos] return df.close[-1]
  1. get_quote_table (Issue 110)
  • FutureWarning: Passing literal html to 'read_html' is deprecated and will be removed in a future version. To read from a literal string, wrap it in a 'StringIO' object. tables = pd.read_html(requests.get(site, headers=headers).text)

  • AttributeError: 'DataFrame' object has no attribute 'append'

@NickJackolson
Copy link

Ran into the same thing today with get_live_price(). I can verify the commit fixes that issue.

@peanutsee
Copy link

get_quote_table() doesn't seem to be working anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants