Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix [get_quote_table -> error 'DataFrame' object has no attribute 'append'] and some other related updations #113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bug Fix [get_quote_table -> error 'DataFrame' object has no attribute 'append'] and some other related updations #113

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09fed2b
update get_quote_table function
jayantverma2809 Jan 28, 2024
18d260a
Update get_stats function
jayantverma2809 Jan 28, 2024
018e8d9
update get_stats_valuation function
jayantverma2809 Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions yahoo_fin/stock_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from Crypto.Util.Padding import unpad
# For pretty print
from pprint import pp
from io import StringIO


try:
Expand Down Expand Up @@ -287,7 +288,7 @@ def tickers_ftse250(include_company_data = False):
return sorted(table.Ticker.tolist())




def get_quote_table(ticker , dict_result = True, headers = {'User-agent': 'Mozilla/5.0'}):

Expand All @@ -300,17 +301,16 @@ def get_quote_table(ticker , dict_result = True, headers = {'User-agent': 'Mozil

site = "https://finance.yahoo.com/quote/" + ticker + "?p=" + ticker

tables = pd.read_html(requests.get(site, headers=headers).text)

data = pd.concat([tables[0], tables[1]])

tables = pd.read_html(StringIO(requests.get(site, headers=headers).text))

data = pd.concat([tables[0], tables[1]], axis=0)

data.columns = ["attribute" , "value"]

quote_price = pd.DataFrame(["Quote Price", get_live_price(ticker)]).transpose()
quote_price.columns = data.columns.copy()

data = pd.concat([data, quote_price])
data = pd.concat([data, quote_price], axis=0)

data = data.sort_values("attribute")

Expand Down Expand Up @@ -338,13 +338,13 @@ def get_stats(ticker, headers = {'User-agent': 'Mozilla/5.0'}):
"/key-statistics?p=" + ticker


tables = pd.read_html(requests.get(stats_site, headers=headers).text)
tables = pd.read_html(StringIO(requests.get(stats_site, headers=headers).text))

tables = [table for table in tables[1:] if table.shape[1] == 2]

table = tables[0]
for elt in tables[1:]:
table = pd.concat([table, elt])
table = pd.concat(tables, ignore_index=True)
# table = tables[0]
# for elt in tables[1:]:
# table = table.append(elt)

table.columns = ["Attribute" , "Value"]

Expand All @@ -365,7 +365,7 @@ def get_stats_valuation(ticker, headers = {'User-agent': 'Mozilla/5.0'}):
"/key-statistics?p=" + ticker


tables = pd.read_html(requests.get(stats_site, headers=headers).text)
tables = pd.read_html(StringIO(requests.get(stats_site, headers=headers).text))

tables = [table for table in tables if "Trailing P/E" in table.iloc[:,0].tolist()]

Expand Down