Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: at_persistence_secondary_server: Add "PublicKeyHash" to the "AtMetadata" and run dart formatter #2159

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

feat: at_persistence_secondary_server: Add "PublicKeyHash" to the "AtMetadata" and run dart formatter #2159

wants to merge 1 commit into from

Conversation

sitaram-kalluri
Copy link
Member

@sitaram-kalluri sitaram-kalluri commented Nov 25, 2024 •
edited
Loading

- What I did

  • Add "PublicKeyHash" to AtMetadata which holds the hash value of encryption public key.
  • Add Hive type adapter to store the "PublicKeyHash" value to hive box
  • Upgrade the dependencies for lints and test packages.
  • Run dart formatter

- How to verify it

  • Updated the unit test to ensure the publicKeyHash is stored in to hive keystore and retrieved.

- Description for the changelog

  • feat: Add "PublicKeyHash" to the "AtMetadata"

@sitaram-kalluri sitaram-kalluri mentioned this pull request Nov 25, 2024
Open
gkc
gkc reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for @murali-shris to review and approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc left review comments

@murali-shris murali-shris murali-shris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sitaram-kalluri @gkc @murali-shris