Skip to content

Commit

Permalink
Merge pull request #1452 from atsign-foundation/gkc-fix-deps
Browse files Browse the repository at this point in the history
build: one more tweak to node package pinning
  • Loading branch information
gkc authored Oct 14, 2024
2 parents 2fdfe9e + dc4a6c8 commit ce49010
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 6 deletions.
1 change: 0 additions & 1 deletion .github/workflows/multibuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ jobs:
- name: build admin webapp
working-directory: ./apps/admin/webapp
run: |
npm install -g [email protected]
npm ci
npm run build
- if: ${{ matrix.os != 'windows-latest' }}
Expand Down
2 changes: 1 addition & 1 deletion apps/admin/webapp/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/admin/webapp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
},
"engines": {
"node": ">=v20.15.0 <23",
"npm": "10.8.2"
"npm": ">=10.8.2"
}
}
1 change: 0 additions & 1 deletion packages/dart/sshnoports/buildArchive
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ echo "Compiling admin_api"; dart compile exe --verbosity error bin/np_admin.dart
wait
cd ../webapp || exit 1
echo "Building admin webapp"
npm install -g [email protected] || exit 1
npm ci || exit 1
npm run build || exit 1

Expand Down
3 changes: 1 addition & 2 deletions tools/multibuild/Dockerfile.package
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ WORKDIR /noports
# install node for later (keep at the top file to increase cache hits)
# hadolint ignore=DL3008
RUN apt-get update; \
apt-get install -y --no-install-recommends npm; \
npm install -g [email protected]
apt-get install -y --no-install-recommends npm

COPY . .

Expand Down

0 comments on commit ce49010

Please sign in to comment.