-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gui windows installer + sshnpd service #1217
Open
Xlin123
wants to merge
74
commits into
trunk
Choose a base branch
from
xlin-windows-installer
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undation/noports into xlin-windows-installer
…undation/noports into xlin-windows-installer
tools/windows-installer/SshnpdService/Properties/PublishProfiles/FolderProfile.pubxml.user
Outdated
Show resolved
Hide resolved
XavierChanth
previously approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one concern, lgtm
feat: at_activate wrapper
Oops... I don't have commit signing setup on Windows. |
XavierChanth
changed the base branch from
trunk
to
1412-add-onboarding-screen-to-npt-flutter
October 9, 2024 12:53
XavierChanth
changed the base branch from
1412-add-onboarding-screen-to-npt-flutter
to
trunk
October 9, 2024 12:54
XavierChanth
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Created a windows installer to allow easy & supported installs on windows machines
Created a proper windows service to allow sshnpd to interact with the OS like other windows services.
Programmatically signs the executables in the windows binary as part of the "NoPorts" app, in order to avoid any issues with anti-viruses.
How I did it
I looked into WiX, VS Installer and Inno Setup and all of them are almost impossible to use for our use case... so instead I started to create a WPF App as the installer. The one downside to this is I couldn't get it to compile as a msi... but all the benefits of an msi can be used from the windows C++ dlls' (See ServiceInstaller.cs).
So with that here are some windows features we now support 🤠
NEW OF SEPT 22
** How to verify it**
I'll build it once I'm done and throw it in here probably.
Important Note
Create a directory in
C:\Program Files\NoPorts\sshnp\
and place the SshnpdService.exe inside that directory.The SshnpdService.exe should be inside the windows bundle, but I haven't created a release for it yet.
- Description for the changelog
feat: gui windows installer + sshnpd service