feat: relax restrictions on device name #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow hyphens in device name - binaries (npt, sshnp) call new function snakifyDeviceName which - converts uppercase latin chars to lowercase - converts whitespace to underscores
…hat we can have a unit test that doesn't take 15 seconds feat: modified default timeout of `getHostAndPortFromSrvd` to 20 seconds from 15 seconds
XavierChanth
reviewed
Oct 2, 2024
| /// whitespace replaced with underscores. Note that multiple consecutive | ||
| /// whitespace characters will be replaced by a single underscore. | ||
| String snakifyDeviceName(String deviceName) { | ||
| return deviceName.toLowerCase().replaceAll(RegExp(r'\s+'), '_'); |
XavierChanth
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Resolves #1403
- How I did it
invalidDeviceNamefunctionsnakifyDeviceNamefunctionsnakifyDeviceNamebefore creating NptParams / SshnpParams- How to verify it
Tests pass
- Additional context
Also made some changes to allow a slow unit test to run more rapidly