Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tid set to null #1526

Merged
merged 3 commits into from
Nov 12, 2024
Merged

fix: tid set to null #1526

merged 3 commits into from
Nov 12, 2024

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Nov 12, 2024

fixes #1524

The problem:

  • If the first thread for srv is created, but the second one fails, then the thread_id for joined thread is not set.

- What I did

  • I reverted my changes setting tid to NULL, which didn't actually fix the problem, this was a one-off in a bulk of changes to struct initializers.
  • I instead added a boolean value which, if the second thread fails to create, skips checking which thread tid is. It instead triggers the cancel for the first thread, since we know the first thread is the open one at this point.

- How I did it

- How to verify it

- Description for the changelog
fix: tid set to null

@XavierChanth XavierChanth requested a review from cpswan November 12, 2024 14:24
@XavierChanth
Copy link
Member Author

@cpswan do I need to update version? We have no binaries uploaded for 0.2.4,
so I think we can re-release under that?

@cpswan
Copy link
Member

cpswan commented Nov 12, 2024

@XavierChanth if you think this fixes #1524 then I'm happy for c0.2.4 to be re-released - so no need to bump

@XavierChanth
Copy link
Member Author

Waiting for e2e tests as a preliminary sanity check

@XavierChanth XavierChanth merged commit 2b81478 into trunk Nov 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants