fix: Npt desktop onboarding #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- status and error visual indicators to be implemented
CurtlyCritchlow
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Reimplemented the activate flow and got it working correctly
Fixed backup keys button in settings, since backup during activation is not available in this new flow.
Left comments of
TODO: localizefor every string that needs to be localizedLeft a comment of
TODO: localize locale - right now hardcoded to englishwhere the localizations for AtOnboardingLocalizations must be set so it matches the app locale.- How I did it
- How to verify it
- Description for the changelog
fix: Npt desktop onboarding