Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update config to 0.15.8 #2580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jongy
Copy link

@Jongy Jongy commented Feb 10, 2025

Resolves: #2428
Resolves: #2012

config 0.15.8 contains the fix for rust-cli/config-rs#579 which causes the crash mentioned in the ticket here.

I tested the resulting atuin binary manually, in a non-Unicode directory on my Linux box - the atuin binary I use daily (18.3.0) crashes due to PWD being non-Unicode, and the built atuin binary does not. I did not run any further tests (is CI enough for this?) or look if anything in particular changed in config's API across the changed versions.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@akinomyoga
Copy link
Contributor

akinomyoga commented Feb 10, 2025

Does this also fix #2012?

edit: You can find a reduced reproducer of #2012 in comment #2012 (comment).

@Jongy
Copy link
Author

Jongy commented Feb 11, 2025

@akinomyoga yes, it fixes that issue as well. config will no longer panic if the faulty env var is filtered out; atuin uses Environment::with_prefix("atuin") so environment variables like a, PWD are filtered out. faulty env vars that are filtered in would still cause a crash, but that's just misuse.

@akinomyoga
Copy link
Contributor

Thanks!

This fixes a panic when non-Unicode environment variables are
processed by atuin.
@Jongy Jongy changed the title Don't panic on non-Unicode environment variables (config 0.15.8) chore(deps): Update config to 0.15.8 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants