Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4875: Import from URL not working #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

iam-TJ
Copy link

@iam-TJ iam-TJ commented Oct 25, 2011

@harriswong
Copy link
Collaborator

I tried using the branch but it gave me a blank page after import. Seems to be caused by the newlines at EOF in both files. You don't need to make another pull request, this should update itself, I will merge it afterwards, thanks!

@cindyli
Copy link
Collaborator

cindyli commented Nov 2, 2011

Hi TJ, thanks for the great contribution. Totally awesome!

Regarding harris' comment on this pull request, I don't see any new commit attempting to resolve it. Let me know if any help you need. Thanks.

@iam-TJ
Copy link
Author

iam-TJ commented Nov 5, 2011

Me neither; Harris, can you revisit this please?

@harriswong
Copy link
Collaborator

Sure would you like me to change that for you? You can also remove those on your branch, and push it to your github origin, it will automatically reflects the changes here.

@iam-TJ
Copy link
Author

iam-TJ commented Nov 6, 2011

You're referring to the "newlines at EOF" you mentioned earlier? I haven't experienced that issue at all - what platform are you testing on?

@harriswong
Copy link
Collaborator

Hi, I was doing this on my macbookpro platform, via pull from your branch as a remote. Here is the line that have some newline:
https://github.com/iam-TJ/AContent/blob/d09c6421f8293c7d6d2ec5d5a97ec51cbc8f6947/include/classes/HTTPRequest.class.php#L134-135

Can sometimes cause premature sending of the HTTP Headers resulting in the user seeing
blank pages instead of content.
catiaprandi referenced this pull request in catiaprandi/AContent Sep 3, 2012
Update include/side_menu.inc.php
atutor pushed a commit that referenced this pull request Aug 11, 2016
Fix warning on translator: Missing argument 2 for AT_print()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants