-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 4875: Import from URL not working #1
base: master
Are you sure you want to change the base?
Conversation
…ut fopen() or curl
I tried using the branch but it gave me a blank page after import. Seems to be caused by the newlines at EOF in both files. You don't need to make another pull request, this should update itself, I will merge it afterwards, thanks! |
Hi TJ, thanks for the great contribution. Totally awesome! Regarding harris' comment on this pull request, I don't see any new commit attempting to resolve it. Let me know if any help you need. Thanks. |
Me neither; Harris, can you revisit this please? |
Sure would you like me to change that for you? You can also remove those on your branch, and push it to your github origin, it will automatically reflects the changes here. |
You're referring to the "newlines at EOF" you mentioned earlier? I haven't experienced that issue at all - what platform are you testing on? |
Hi, I was doing this on my macbookpro platform, via pull from your branch as a remote. Here is the line that have some newline: |
Can sometimes cause premature sending of the HTTP Headers resulting in the user seeing blank pages instead of content.
Update include/side_menu.inc.php
Fix warning on translator: Missing argument 2 for AT_print()
See http://atutor.ca/atutor/mantis/view.php?id=4875