Support for virtIO sound #37
Conversation
alexandermbrown
force-pushed
the
virtio_snd
branch
from
1f7e5db to
efc8b3d
Compare
alexandermbrown
force-pushed
the
virtio_snd
branch
from
e43b377 to
749c901
Compare
alexandermbrown
force-pushed
the
virtio_snd
branch
2 times, most recently
from
782e385 to
dc537d3
Compare
alexandermbrown
force-pushed
the
virtio_snd
branch
2 times, most recently
from
b874c23 to
4666b28
Compare
There was a problem hiding this comment.
I have written some minor things down to change but the major thing seems to be that this will need to rebase once Eric's block PR is merged. It's a bit hard to review with all of his changes in this PR as well (my fault, should've been quicker about merging things).
The SOUND.md documentation is good, but we will need to put the relevant bits in the right place. Some of it belongs in the README for the virtio example, some of it belongs in the manual.
I see that the virtio-snd example still exists and is not merged with the virtio example? Are you waiting for Eric's PR to go through first?
I think we discussed offline about how legally we can't include some of the example sound files due to copyright? We should fix that as well.
The design and implementation of the user-level side and virtIO device we can discuss together offline since it's easier.
alexandermbrown
force-pushed
the
virtio_snd
branch
from
b7afe3a to
2898afa
Compare
alexandermbrown
force-pushed
the
virtio_snd
branch
from
2a31ef3 to
8ad5f42
Compare
Ivan-Velickovic
force-pushed
the
virtio_snd
branch
from
b86ac87 to
e0d191d
Compare
|
Make a GitHub issue for any future work, I will start commenting what I think should go into the issue as future work. Also, if possible any |
|
Can you check |
|
Minor point, all good if not possible though, do you have SVGs for the diagrams instead of PNGs? |
Looks good |
Done in 01068d6 |
Ivan-Velickovic
force-pushed
the
virtio_snd
branch
from
3bceded to
01068d6
Compare
Ivan-Velickovic
force-pushed
the
virtio_snd
branch
from
ba288af to
f4a58a3
Compare
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Ivan-Velickovic
force-pushed
the
virtio_snd
branch
from
f4a58a3 to
3a13e47
Compare
Not necessary for this example Signed-off-by: Ivan Velickovic <[email protected]>
| #pragma once | ||
|
|
||
| // Qemu faults if you try load or store with a strict memorder on aarch64. | ||
| #ifdef BOARD_qemu_arm_virt |
There was a problem hiding this comment.
Just making a note here so I don't forget that we should return to do this. I'll chuck it in a GitHub issue soon.
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
| @@ -240,7 +249,7 @@ int virtio_console_handle_rx(struct virtio_device *dev) | |||
| rx_queue->last_idx++; | |||
|
|
|||
| // 3. Inject IRQ to guest | |||
| // @ivanv: is setting interrupt status necesary? | |||
| // @ivanv: is setting interrupt status necessary? | |||
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
This PR adds a virtIO sound device, along with an example Linux userlevel sound driver.