Building virtio example with zig #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichchan999
force-pushed
the
virtio_blk_zig
branch
from
244946e
to
6b66656
Compare
erichchan999
force-pushed
the
virtio_blk_zig
branch
5 times, most recently
from
b303783
to
5d5e5c6
Compare
erichchan999
force-pushed
the
virtio_blk_zig
branch
3 times, most recently
from
7407ca5
to
882622c
Compare
build.zig
Outdated
Comment on lines
89
to
94
| // @ivanv: fix all of our libvmm includes! This is a mess! | ||
| libvmm.addIncludePath(b.path("src")); | ||
| libvmm.addIncludePath(b.path("src/util/")); | ||
| libvmm.addIncludePath(b.path("src/util")); | ||
| libvmm.addIncludePath(b.path("src/virtio")); | ||
| libvmm.addIncludePath(b.path("src/arch/aarch64")); | ||
| libvmm.addIncludePath(b.path("src/arch/aarch64/vgic/")); | ||
| libvmm.addIncludePath(b.path("src/arch/aarch64/vgic")); |
There was a problem hiding this comment.
Once you rebase on main we can remove all these lines, finally.
Comment on lines
+433
to
+339
| const microkit_tool_cmd = b.addSystemCommand(&[_][]const u8{ | ||
| microkit_tool.getPath(b), | ||
| }); | ||
| microkit_tool_cmd.addFileArg(system_description_path); | ||
| microkit_tool_cmd.addArg("--search-path"); | ||
| microkit_tool_cmd.addArg(b.getInstallPath(.bin, "")); | ||
| microkit_tool_cmd.addArg("--board"); | ||
| microkit_tool_cmd.addArg(@tagName(microkit_board)); | ||
| microkit_tool_cmd.addArg("--config"); | ||
| microkit_tool_cmd.addArg(@tagName(microkit_config)); | ||
| microkit_tool_cmd.addArg("-o"); | ||
| microkit_tool_cmd.addArg(final_image_dest); | ||
| microkit_tool_cmd.addArg("-r"); | ||
| microkit_tool_cmd.addArg(b.getInstallPath(.prefix, "./report.txt")); | ||
| microkit_tool_cmd.step.dependOn(b.getInstallStep()); |
There was a problem hiding this comment.
Can you follow what examples/simple/build.zig does for this?
Ivan-Velickovic
force-pushed
the
virtio_blk_zig
branch
3 times, most recently
from
5c6fd2c
to
d5fee93
Compare
Ivan-Velickovic
force-pushed
the
virtio_blk_zig
branch
from
d5fee93
to
24e1d9f
Compare
Signed-off-by: Eric Chan <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Eric Chan <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Eric Chan <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Eric Chan <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Eric Chan <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
…s is done for odroidc4 example Signed-off-by: Eric Chan <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Eric Chan <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Eric Chan <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
There's an issue with Microkit 1.4.0 that affects the Odroid-C4. Signed-off-by: Ivan Velickovic <[email protected]>
Ivan-Velickovic
force-pushed
the
virtio_blk_zig
branch
from
24e1d9f
to
fc775ae
Compare
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Ivan-Velickovic
force-pushed
the
virtio_blk_zig
branch
from
77e93ca
to
44f75b6
Compare
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Ivan-Velickovic
force-pushed
the
virtio_blk_zig
branch
from
94491b1
to
10d814d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on this PR #74 to be merged first.
Provides zig build for virtio example. Changes the top-level build.zig in libvmm to have sddf build.zig as a dependency.