Rework serial config files #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Courtney3141
force-pushed
the
rework_serial_config_files
branch
2 times, most recently
from
8b0e1ac
to
3850432
Compare
Courtney3141
force-pushed
the
rework_serial_config_files
branch
from
3850432
to
a5c295a
Compare
Signed-off-by: Courtney Darville <[email protected]>
Signed-off-by: Courtney Darville <[email protected]>
Signed-off-by: Courtney Darville <[email protected]>
Signed-off-by: Courtney Darville <[email protected]>
Courtney3141
force-pushed
the
rework_serial_config_files
branch
from
a5c295a
to
9fe672d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigns the serial config files in line with the ethernet config files updated here #203.
Rather than initialising the serial queues on behalf of the components, the config functions now initialise the variables required by the components to initialise the queues, allowing the components to initialise their own queues.
In the case of the serial clients, this is just the capacity of the serial queues. For the virtualisers, this PR introduces a
serial_queue_infostruct (like thenet_queue_infostruct), which contains client queue addresses, capacity and data region addresses. A struct is initialised for each client, allowing the virtualisers to initialise client queues with the struct.Note that this PR is based off #255, and should be merged secondary to that.