Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pinctrl driver for imx and meson #262

Draft
wants to merge 138 commits into
base: main
Choose a base branch
from
Draft

Add pinctrl driver for imx and meson #262

wants to merge 138 commits into from

Conversation

dreamliner787-9
Copy link

@dreamliner787-9 dreamliner787-9 commented Sep 27, 2024 •
edited
Loading

Draft right now because there are still a few things to clean up. Namely:

  • Should we stick with Python for DTS parsing

This pull request:

  • Add pinctrl (also known as pinmux) driver for imx and meson into sDDF.
  • Integrate pinctrl driver into the I2C example system.
    • If a user wants to change the I2C bus, they will need to modify the supplied DTS file.

This PR should be squashed before merging.

@dreamliner787-9 dreamliner787-9 added meson Devices on a Meson platform - e.g. ODROID C4 enhancement New feature or request labels Sep 27, 2024
@Ivan-Velickovic
Copy link
Collaborator

Add ability to toggle pinctrl initialisation from the meson I2C driver with a macro.
There is now a soft dependancy on pinctrl from i2c, if a client wants native pinctrl driver, they will need to supply a DTS.

We should not let the I2C driver do its own pinctrl initialisation - the dependency on the pinctrl driver should be a requirement in my opinion.

Michael-M34 and others added 24 commits October 9, 2024 13:17
@Michael-M34 @dreamliner787-9
Skeleton complete + scanning of device tree complete
34ea723
@Michael-M34 @dreamliner787-9
Added some notes about current progress + to-do
d411ad9
@dreamliner787-9
iomuxc: rename pinmux driver to iomuxc, add MaaXBoard DTS and make a …
acf1f42 
…working skeleton of static iomuxc driver

Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
iomuxc: remove old pinmux example
71aaf92 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
iomuxc: make DTS parsing script take in the SoC name as an argument
b4641c1 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
iomuxc: removed driver implementation file from driver.c to iomuxc.c
41e689c 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
iomuxc: general clean up and switch to Microkit 1.4.0
bb2673b 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
iomuxc -> pinctrl: rename to match Linux's equivalent
fd374f3 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: add Makefile snippet for pinctrl driver and move example sys…
ec4eb2e 
…tem to example folder

Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: rename pinmux.system to pinctrl.system
6f1541e 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: add Makefile snippets
99583e5 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: example system now compiles
d1da51c 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: move example system into a subfolder so we can have many pin…
e8d9d2f 
…ctrl examples in the future

Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: add libmicrokitco submodule to block on timer in pinctrl exa…
18577db 
…mple

Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: complete simple pinctrl example, redirecting serial
d8dd35c 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: align 4 bytes in python DTS parse script
51881ec 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: add client interface and proper logging to driver
85c62aa 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: copy echo server example into pinctrl examples directory
2c2278e
@dreamliner787-9
pinctrl: pinctrl_driver.mk: compile with debug prints by default for now
7fbf26c 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: apply changes to echo server example to have pinmux driver i…
0ae316f 
…ntegrated

Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: implement proper driver logging
74a4346 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: improve driver logging format
cb3cbe0 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: add copyright
2aace4a 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: add copyright
67176ab 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: implement read checking after write for registers
9e6bfdc 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: break meson memory range definnition into common header file
0dcff7a 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: fix odroidc4 dts to enable hdmi device
b7c4c80 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: track DTS changes
a211d73 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: track changes to parsing script
a92a618 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: turn off GPIO for any muxed pads in meson
d4c954d 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: make pinctrl_memranges.h standalone
0d9b181 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: fix incorrect base register address variable
9f9201d 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: fix missing newline in logging
3ae3f4a 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: add undocumented HDMI pinmux registers for meson
9a41bdd 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: apply more stringent error checking for meson dts script
06415e5 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
i2c: allow pinmux initialisation to be toggled in the makefile
ecd5a77 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
remove pinctrl driver from echo server
4c41e55 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: style: remove trailling whitespaces
794bfc9 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: style: remove trailling whitespaces...
909e563 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: style: run clang-format
472dfba 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
i2c: disable pinmux initialisation
70f619a 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
i2c: update docs to reference LionsOS
18dca19 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
i2c: integrate pinctrl driver into example's Make build system
9d406ce 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
pinctrl: checkpoint, delete pinctrl example
6487bda 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
i2c: remove gpio header
e71caaf 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
i2c: fix driver code style
24503ce 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
i2c: fix driver makefile snippet style
0e2ab3d 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
ci: install py module devicetree for build_i2c_make
432826a 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
ci: try pipx for py devicetree
980fbe6 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
licences: add GPL 2.0 only for DTS file from linux
1993f01 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
i2c: give default python interpreter
24c4911 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
echo_server: remove reference to pinctrl in build system
0ce9880 
Signed-off-by: Bill Nguyen <[email protected]>
@dreamliner787-9
ci: temparily disable i2c building while discussions on the python DT…
3380016 
…S parse script are ongoing

Signed-off-by: Bill Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request meson Devices on a Meson platform - e.g. ODROID C4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamliner787-9 @Ivan-Velickovic @Michael-M34