This repository has been archived by the owner on Jun 16, 2024. It is now read-only.
Skip entities which have no friendly_name and haaska_name properties #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the same problem. Solved it another way, but this may be the better implementation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the problem that initially no entities were found by Alexa and the following was logged:
Discovery failed: 'friendly_name'. Turns out that I have an entity in my local setup wherefriendly_nameis not set, for whatever reason.This PR should skip such entities by simply filtering them. Of course, if there
s ahaaska_name` configured, it should work as this is being used when building the response object for Alexa.