refactor: minor changes

aulasoftwarelibre · Jan 14, 2024 · e5d3cf3 · e5d3cf3
1 parent 323bafa
commit e5d3cf3
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/src/components/input-form/input-form.tsx b/src/components/input-form/input-form.tsx
@@ -4,8 +4,8 @@ import { Input, InputProps } from '@nextui-org/react'
 
 import FormResponse from '@/lib/zod/form-response'
 
-type FormInputProperties = InputProps & {
-  label: string
+export type FormInputProperties = InputProps & {
+  label?: string
   state: FormResponse<unknown>
 }
 

diff --git a/src/core/book/application/__tests__/loan-book.use-case.spec.ts b/src/core/book/application/__tests__/loan-book.use-case.spec.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest'
 
-import { LoanBookUseCase } from '@/core/book/application/loan-book-use.case'
+import LoanBookUseCase from '@/core/book/application/loan-book-use.case'
 import LoanBookRequest from '@/core/book/dto/requests/loan-book.request'
 import BooksInMemory from '@/core/book/infrastructure/services/books-in-memory.repository'
 import ApplicationError from '@/core/common/domain/errors/application-error'

diff --git a/src/core/book/application/loan-book-use.case.ts b/src/core/book/application/loan-book-use.case.ts
@@ -5,7 +5,7 @@ import BookId from '@/core/common/domain/value-objects/book-id'
 import UserId from '@/core/common/domain/value-objects/user-id'
 import LoanBookService from '@/core/loan/domain/services/loan-book.service'
 
-export class LoanBookUseCase {
+export default class LoanBookUseCase {
   constructor(
     private readonly books: Books,
     private readonly loanBookService: LoanBookService,

diff --git a/src/core/common/domain/value-objects/__tests__/fullname.spec.ts b/src/core/common/domain/value-objects/__tests__/fullname.spec.ts
@@ -25,9 +25,9 @@ describe('FullName', () => {
       )
     })
 
-    it('should return a FullNameError for an invalid name', () => {
+    it('should return a FullNameError for an long name', () => {
       // Arrange
-      const invalidName = 'Jo' // Name length is less than 3
+      const invalidName = 'A'.repeat(65)
 
       // Act
       const result = FullName.create(invalidName)

diff --git a/src/core/common/domain/value-objects/fullname.ts b/src/core/common/domain/value-objects/fullname.ts
@@ -6,10 +6,14 @@ export default class FullName {
   constructor(public readonly value: string) {}
 
   public static create(author: string): Result<FullName, DomainError> {
-    if (!author || author.length < 3) {
+    if (!author || author.length === 0) {
       return DomainError.cause('El nombre es demasiado corto.')
     }
 
+    if (author.length > 64) {
+      return DomainError.cause('El nombre es demasiado largo.')
+    }
+
     return ok(new FullName(author))
   }
 }