-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for meshes and/or vectors with fewer than 3 dimensions #78
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 167222a.
Codecov ReportAttention: Patch coverage is
|
This makes sure the correct type of collection is implemented based on the dimension of the mesh and desired vector dimension.
…to cmacmackin/lower-dims
MFEM example 31 used a matrix diffusion coefficient but we haven't yet added support for matrix quantities to Platypus. This seems like something it would be best to think about a bit, rather than rush into. As such, I've decided against using that test problem in this PR. Instead I decided to merge in #55, so that I can solve the irrotational vortex problem using a velocity potential field, then use an AuxKernel to take the grad of the potential to get the velocity. This test works and demonstrates the use of 2D vectors in 2D space. This PR will be ready for review once #55 has been merged into main. |
CodeCov is complaining because the stuff I added to MFEMProblem to handle mixed bilinear forms isn't being tested. I'm not too concerned about this, but if it is considered important then someone can try adding an additional integration test that will be covered it (I'm not sure I'd have the expertise). |
I'm happy with this, since @bryceshirley is currently writing a mixed form test for the Darcy problem anyway and these additions will certainly help with that. |
Currently Platypus makes all finite element spaces 3D, meaning that 3D meshes must be used. It does not support any situation where either meshes or vectors have fewer than 3 dimensions. This pull request seeks to add support for those cases.
It implements a test problem (MFEM example 31) for a 2D mesh.It also adds support for and L2 error post-processor.A change was made to ensure that mixed bilinear forms are correctly initialised. This was to support an earlier, naive, attempt at a different test case. It is not used in any of the integration tests.