Adds proxy as option to request #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (proxy) { | ||
| request = { | ||
| host: proxy, | ||
| path: (options.query.https ? "https" : "http") + "://" + API_HOSTNAME + API_BASE_PATH + options.api + endpoint + query, |
There was a problem hiding this comment.
Instead of options.query.https, can we use this.https from the https option in the constructor? What are your thoughts @JonathanWexler?
|
Thank you for the PR @JonathanWexler! I'm sorry for the late response. Let me know what you think of the comment above. |
|
Is this still something you're interested in exploring @JonathanWexler? |
|
Sorry for the delay, I agree with you. When I get a chance to apply those changes I’ll make a change to the PR. Thanks for following up.
… On Jun 18, 2018, at 10:43 AM, Austin Kelleher ***@***.***> wrote:
Is this still something you're interested in exploring @JonathanWexler?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Awesome thanks @JonathanWexler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll clean this up. But just wanted to get this out there first. This adds the ability to enter a proxy as an option. I needed this to test in a secure network.