Update samples to use okta spring boot starter and spring boot 3 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraible
reviewed
Oct 24, 2023
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip | |||
There was a problem hiding this comment.
8.4 is the latest version and would be better for Java 21 compatibility. https://docs.gradle.org/8.4/release-notes.html
Suggested change
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip | |
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip |
mraible
reviewed
Oct 24, 2023
| /** | ||
| * Configures our application with Spring Security to restrict access to our API endpoints. | ||
| */ | ||
| @Configuration | ||
| @EnableWebSecurity |
There was a problem hiding this comment.
@EnableWebSecurity is not needed if it's a Spring Boot app. It's only necessary for Spring apps w/o Boot.
frederikprijck
previously approved these changes
Oct 24, 2023
|
Think we will need auth0-samples/api-quickstarts-tests#6 for the API quickstarts test to run. |
Co-authored-by: Frederik Prijck <[email protected]>
Co-authored-by: Frederik Prijck <[email protected]>
poovamraj
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the servlet and webflux samples to:
A corresponding quickstart article change will also be made.