Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplifies credential manager dispatch #903

Closed
wants to merge 1 commit into from
Closed

fix: simplifies credential manager dispatch #903

wants to merge 1 commit into from

Conversation

adigitalmonk
Copy link

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

📎 References

🎯 Testing

@adigitalmonk adigitalmonk requested a review from a team as a code owner February 17, 2025 18:27
@adigitalmonk
Copy link
Author

I meant to open this to my personal fork first, apologies.

@Widcket
Copy link
Contributor

Widcket commented Feb 17, 2025

Hi @adigitalmonk, please be aware we would not accept such a PR because using sync() will not by itself serialize an async operation such as a network request. See #734 (comment)

@adigitalmonk
Copy link
Author

Thanks for the context thread, @Widcket ! I want to make sure I cross my T's and dot my I's before I actually send anything your way. 🙇🏽‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adigitalmonk @Widcket