Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add errSecMissingEntitlement error #224

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

grdsdev
Copy link

@grdsdev grdsdev commented Oct 14, 2024

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Add a new error case for the errSecMissingEntitlement status.

📎 References

🎯 Testing

Tries to use SimpleKeychain with access group without adding the access group to the app's entitlement, you should get the new added error.

@grdsdev
Copy link
Author

grdsdev commented Jan 30, 2025

Hey @Widcket what is needed to get this out?

@Widcket
Copy link
Contributor

Widcket commented Jan 30, 2025

Hi @grdsdev, thanks for your contribution. Besides the failed Snyk check (we're sorting that out), we'll need your commits to be verified.

grdsdev and others added 4 commits January 30, 2025 15:30
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@grdsdev
Copy link
Author

grdsdev commented Jan 30, 2025

@Widcket done, signed commits

@Widcket Widcket enabled auto-merge (squash) January 30, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants