Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support For BYOK with community contribution #782

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

kishore7snehil
Copy link
Contributor

@kishore7snehil kishore7snehil commented Nov 13, 2024

Contributing Changes

Changes

Following endpoints have been added :

  • GET /api/v2/keys/encryption
  • POST /api/v2/keys/encryption
  • GET /api/v2/keys/encryption/{kid}
  • DELETE /api/v2/keys/encryption/{kid}
  • POST /api/v2/keys/encryption/{kid}
  • POST /api/v2/keys/encryption/{kid}/wrapping-key

References

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Contributor Checklist

@kishore7snehil kishore7snehil requested a review from a team as a code owner November 13, 2024 07:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (5d132ad) to head (f03146e).
Report is 20 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##                main     #782      +/-   ##
=============================================
- Coverage     100.00%   99.87%   -0.13%     
- Complexity      1383     1392       +9     
=============================================
  Files             62       63       +1     
  Lines           4781     4857      +76     
=============================================
+ Hits            4781     4851      +70     
- Misses             0        6       +6     
Flag Coverage Δ
unittestsvalidate 99.87% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kishore7snehil kishore7snehil merged commit e7d9916 into main Nov 13, 2024
22 checks passed
@kishore7snehil kishore7snehil deleted the feature/support-for-byok branch November 13, 2024 11:17
@kishore7snehil kishore7snehil mentioned this pull request Nov 15, 2024
kishore7snehil added a commit that referenced this pull request Nov 15, 2024
Added

- #782
([kishore7snehil](https://github.com/kishore7snehil))

- #783
([kishore7snehil](https://github.com/kishore7snehil))

Fixed

- Adjusted link typo on codeExchange method to the right url
([#782](#782))
([GabrielBrittoDev](https://github.com/GabrielBrittoDev))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants