DXCDT-499: Add abstractions to fetch client resource data in tf cmd #794
Conversation
sergiught
force-pushed
the
feature/DXCDT-499-client-data-fetcher
branch
from
9574462
to
409cd11
Compare
| sanitizedName := re.ReplaceAllString(name, "") | ||
|
|
||
| // Regular expression pattern to remove leading digits or dashes. | ||
| namePattern = "^[0-9-]+" |
There was a problem hiding this comment.
Would it be preferable to match any leading character that is not a letter or underscore?
There was a problem hiding this comment.
How the sanitize works is that it matches invalid characters and removes them, so it's doing the opposite.
There was a problem hiding this comment.
But it's only matching a subset of invalid characters, not all possible invalid characters.
There was a problem hiding this comment.
Ah, you're already removing all the other possible chars in the step above.
There was a problem hiding this comment.
The logic is split in 2 through 2 regexes, the first one removes all invalid characters, and the second one removes digits or - from the start of the string.
There was a problem hiding this comment.
Thanks for the explanation. My bad.
There was a problem hiding this comment.
No worries, happy to clarify 👍🏻
🔧 Changes
This PR adds the ability to fetch the Auth0 Client import data for the
auth0 terraform generatecommand.📚 References
🔬 Testing
📝 Checklist