DXCDT-508: Prevent overwriting already existing files #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
==========================================
+ Coverage 71.98% 72.00% +0.01%
==========================================
Files 91 91
Lines 11405 11447 +42
==========================================
+ Hits 8210 8242 +32
- Misses 2691 2700 +9
- Partials 504 505 +1
☔ View full report in Codecov by Sentry. |
sergiught
force-pushed
the
feature/DXCDT-508-check-file-exists
branch
2 times, most recently
from
bd54da2
to
296e486
Compare
Widcket
reviewed
Aug 10, 2023
internal/cli/terraform.go
Outdated
| outputDIR, | ||
| ) | ||
|
|
||
| if !cli.force && !cli.noInput { |
There was a problem hiding this comment.
Should we use canPrompt(cmd)?
There was a problem hiding this comment.
1d19261 (#798) Updated!
sergiught
force-pushed
the
feature/DXCDT-505-terraform-exec
branch
from
a3bb523
to
fbe8d5e
Compare
sergiught
force-pushed
the
feature/DXCDT-508-check-file-exists
branch
from
d90d266
to
1d19261
Compare
Widcket
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adds a check to ensure the output dir is empty, if it's not it prompts the user to proceed in overwriting the files.
📚 References
🔬 Testing
📝 Checklist