Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure AsyncAgedCache is correctly updated #693

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Ensure AsyncAgedCache is correctly updated #693

merged 2 commits into from
Jan 10, 2024

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Dec 22, 2023 •
edited
Loading

Changes

Once an entry in the AsyncAgedCache is expired, it is not correctly updating the cache. Any subsequent calls will bypass the cache.

This PR ensures expired cache entries are removed from the cache.

References

Closes #692

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner December 22, 2023 08:04
@frederikprijck frederikprijck changed the title Ensure cache is correctly updated Ensure AsyncAgedCache is correctly updated Dec 22, 2023
@frederikprijck frederikprijck enabled auto-merge (squash) December 22, 2023 08:07
@frederikprijck frederikprijck merged commit 24a6502 into master Jan 10, 2024
12 checks passed
@frederikprijck frederikprijck deleted the fix/692 branch January 10, 2024 10:05
@frederikprijck frederikprijck mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frederikprijck @ewanharris