Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for BYOK end-points #743

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Adds support for BYOK end-points #743

merged 1 commit into from
Nov 7, 2024

Conversation

kailash-b
Copy link
Contributor

@kailash-b kailash-b commented Nov 6, 2024

Changes

Added the following end-points :

  • GET /api/v2/keys/encryption
  • POST /api/v2/keys/encryption
  • GET /api/v2/keys/encryption/{kid}
  • DELETE /api/v2/keys/encryption/{kid}
  • POST /api/v2/keys/encryption/{kid}
  • POST /api/v2/keys/encryption/{kid}/wrapping-key

References

Testing

Added the following test cases :

  • Test_encryption_keys_crud_sequence

    • Creates a encryption key
    • Gets the Created encryption key
    • Gets all the encryption keys present
    • Deletes the newly created encryption key
  • Test_import_encrypted_keys

    • Tests that an imported key is parsed successfully.
  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kailash-b kailash-b requested a review from a team as a code owner November 6, 2024 13:49
@kailash-b kailash-b merged commit 1f547ec into master Nov 7, 2024
11 checks passed
@kailash-b kailash-b deleted the feature/byok branch November 7, 2024 06:26
@kailash-b kailash-b mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants