Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pull_request trigger for vulncheck workflow #223

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ewanharris
Copy link
Contributor

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

The action we use references github.sha which in pull_request_target points to the sha of the target branch, so a PR wont ever be scanned. By using pull_request we get the correct sha and their documentation appears to reference this so I can only assume that the sarif upload feature works as expected.

🔧 Changes

📚 References

🔬 Testing

@ewanharris ewanharris requested a review from a team as a code owner October 12, 2023 10:06
@ewanharris
Copy link
Contributor Author

Docker run args are pointing at the correct ref and the upload worked so this should be good GITHUB_REF=refs/pull/223/merge -e GITHUB_SHA=25201ef407ac50d7a6ec724cc6367ad26c32f056

(I think the two govulncheck / scan runs is just an artifact of going from pull_request_target to pull_request

@ewanharris ewanharris merged commit ce76d68 into master Oct 12, 2023
6 of 8 checks passed
@ewanharris ewanharris deleted the ci/vulncheck-trigger branch October 12, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants