Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: express-jwt types #412

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

jfromaniello
Copy link
Member

Description

This is the correct type given that the returned callback can handle both configuration of arguments.

References

This is a mistake I made in #297 and will definitely help with the situation at auth0/express-jwt#288

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

This is the correct type given that the returned
callback can handle both type of arguments.
@evansims evansims merged commit 879a132 into auth0:master Jun 24, 2024
14 checks passed
@Sti2nd
Copy link

Sti2nd commented Jul 3, 2024

Looking forward to this being published to NPM registry 👍🏿 Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants