add serialization error #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2023
vroldanbet
added a commit
to authzed/spicedb
that referenced
this pull request
Oct 2, 2023
with authzed/api#88 a new error reason is exposed to signal datastore serialization errors.
vroldanbet
added a commit
to authzed/spicedb
that referenced
this pull request
Oct 2, 2023
with authzed/api#88 a new error reason is exposed to signal datastore serialization errors.
josephschorr
reviewed
Oct 2, 2023
to support authzed/spicedb#1552
vroldanbet
force-pushed
the
add-serialization-error
branch
from
e68d9e5 to
b3e295b
Compare
vroldanbet
added a commit
to authzed/spicedb
that referenced
this pull request
Oct 3, 2023
with authzed/api#88 a new error reason is exposed to signal datastore serialization errors.
vroldanbet
added a commit
to authzed/spicedb
that referenced
this pull request
Oct 3, 2023
with authzed/api#88 a new error reason is exposed to signal datastore serialization errors.
jzelinskie
approved these changes
Oct 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to support authzed/spicedb#1552
Database serialization errors are not that uncommon when running the backend datastores at isolation level
SERIALIZABLE. However, those errors could be reported in a clearer way to the client instead of some cryptic database error.This adds a new error reason to support providing a typed response when serialization errors happen.