Move debug tracing into the Check request and response #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
previously approved these changes
Mar 13, 2024
| @@ -358,6 +364,9 @@ message CheckPermissionResponse { | |||
|
|
|||
| // partial_caveat_info holds information of a partially-evaluated caveated response | |||
| PartialCaveatInfo partial_caveat_info = 3 [ (validate.rules).message.required = false ]; | |||
|
|
|||
| // debug_trace is the debuggin trace of this check, if requested. | |||
There was a problem hiding this comment.
Suggested change
| // debug_trace is the debuggin trace of this check, if requested. | |
| // debug_trace is the debugging trace of this check, if requested. |
josephschorr
force-pushed
the
debug-trace
branch
from
0a751ea to
78cdd78
Compare
ecordell
approved these changes
Mar 13, 2024
alecmerdler
approved these changes
Mar 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.